Diff for "PoRequiredOption"

Notes on how the Purchase Order Required options on the supplier and salesperson work

• Currently, the option on the supplier record "Po Required to receive stock" take precedence if it is set.

• If the above option is not set (i.e is blank), the options on the sales person come into effect

  • "Po required to receive external stock" for supplier purchase orders

  • "Po required to receive internal stock" for branch transfers

• If the final result is that a purchase order number is required, a number of additional checks should take place. This is true except in the case where the option in regards to internal stock is set (this is a known bug). The checks that do take place are:
  1. Not being allowed to increase the quantity (based on the previous quantity). If blind receipting is being used, the first entry for quantity is allowed regardless.
  2. A check against the stock item being entered is made. If the stock item is not found anywhere on the purchase order, a warning is given to the user, but they are still allowed to continue.

We propose the following:

• Remove the option "Po required to receive internal stock" from the salesperson record

• Rename the option "Po required to receive external stock" by leaving out the term "external"

• Change the precedence of the options in regards to the salesperson and supplier. The logic will be as follows:

  Supplier Option	Salesperson Option	Po Required
  Y	Y	Y
  Y	N	N
  Y	""	Y
  N	Y	N
  N	N	N
  N	""	N
  ""	Y	Y
  ""	N	N
  ""	""	N

  The logic in code format:

  •    po_required = (supp_option == 'n' || sperson_option == 'n') ? NO : 
                    ((supp_option == 'y' || sperson_option == 'y') ? YES : NO);

  The logic in English:

  • The supplier option, if non blank, takes precedence unless the salesperson option is explicitly set to NO. If both supplier and salesperson are blank, a purchase order will not be required.

• We will split the option "Generate stock receipt lines from purchase order" into two options regarding both internal and external stock

• The above mentioned checks will work as they currently do now, by disallowing an increase in the quantity, and giving a warning if attempting to receipt an item not on the purchase order